/ 
HTML-FormHandler-0.40068
⭐ Starred 89 / HTML::FormHandler::Model::CDBI
Security Advisories (1)
CVE-2022-4993 (2026-08-13)

HTML::FormHandler versions through 0.40068 for Perl allow attacker selected method dispatch and resource exhaustion because _apply_actions and add_error use error message text built from request data as a Locale::Maketext bracket notation template. add_error hands its first argument to the language handle as the Locale::Maketext message key, and the default handle's lexicon sets `_AUTO`, so a string that is not a lexicon entry is compiled as a bracket notation template instead of being looked up. In a bracket group the first token names a method called on the language handle and the remaining tokens are its arguments. Three kinds of text the library did not author reach that position. _apply_actions installs a `$SIG{__WARN__}` handler that stores the warning text in `$error_message`, and a captured warning survives a successful action, so a field carrying a numeric transform turns `Argument "[sprintf,%50000000d,0]" isn't numeric` into the template; a warning quotes the submitted value verbatim, so the group is well formed and dispatches. `$error_message ||= $tobj->validate($new_value)` takes a type constraint's own failure message, which renders the rejected value through a partial dumper in bracket and comma form (Devel::PartialDump when Moose can load it, Type::Tiny's own dumper always), so a field with `apply => [ Str ]` given a parameter sent more than once, which arrives as an array, gets `Reference ["a","b"] did not pass type constraint "Str"` as its template, from a request that carries no bracket character of its own. A coercion or transform exception reaches it the same way. Beyond those, a validator whose message contains the field value puts that value in the template directly, and add_error replaces the message list with the contents of an arrayref first argument (`@message = @{$message[0]} if ref $message[0] eq 'ARRAY'`), so a value arriving as an array fills the argument slots from the same request as well. A malformed group such as `[0]` makes the compile croak, and HTML::FormHandler::I18N::maketext and add_error each re-raise that as a die, so process() throws. A well formed group naming sprintf reaches CORE::sprintf with an attacker chosen field width. Any caller that applies a type constraint or a transform to an untrusted field, or whose validator passes an untrusted field value to add_error, can be made to throw an unhandled exception out of process(), or to allocate an arbitrary amount of memory in one request, and an application whose language handle subclass defines side effecting public methods makes those callable with attacker chosen arguments. The dumped type constraint message is bounded to the exception, because both dumpers quote non-numeric elements so the method slot is never an attacker chosen name. The built-in messages pass fixed templates with the value in an argument slot, where it stays inert, and the built-in field types attach explicit message callbacks, so neither is affected.

NAME

HTML::FormHandler::Model::CDBI - Class::DBI model class (non-functioning)

VERSION

version 0.40068

SYNOPSIS

package MyApplication::Form::User;
use strict;
use base 'HTML::FormHandler::Model::CDBI';


# Associate this form with a CDBI class
has '+item_class' => ( default => 'MyDB::User' );

# Define the fields that this form will operate on
sub field_list {
    return {
        [
            name        => 'Text',
            age         => 'PosInteger',
            sex         => 'Select',
            birthdate   => 'DateTimeDMYHM',
        ]
    };
}

DESCRIPTION

A Class::DBI database model for HTML::FormHandler

I don't use CDBI, so this module almost certainly doesn't work. It is only being left here as a starting point in case somebody is interested in getting it to work.

Patches and tests gratefully accepted.

METHODS

item_class

The name of your database class.

init_item

This is called first time $form->item is called. It does the equivalent of:

return $self->item_class->retrieve( $self->item_id );

guess_field_type

Pass in a column and assigns field types. Must set $self->item_class to return the related item class. Returns the type in scalar context, returns the type and maybe the related table in list context.

Currently returns:

DateTime        - for a has_a relationship that isa DateTime
Select          - for a has_a relationship
Multiple        - for a has_many
DateTime        - if the field ends in _time
Text            - otherwise

lookup_options

Returns a array reference of key/value pairs for the column passed in. Calls $field->label_column to get the column name to use as the label. The default is "name". The labels are sorted by Perl's cmp sort.

If there is an "active" column then only active are included, with the exception being if the form (item) has currently selected the inactive item. This allows existing records that reference inactive items to still have those as valid select options. The inactive labels are formatted with brackets to indicate in the select list that they are inactive.

The active column name is determined by calling:

$active_col = $form->can( 'active_column' )
    ? $form->active_column
    : $field->active_column;

Which allows setting the name of the active column globally if your tables are consistently named (all lookup tables have the same column name to indicate they are active), or on a per-field basis.

In addition, if the foreign class is the same as the item's class (or the class returned by item_class) then options pointing to item are excluded. The reason for this is for a table column that points to the same table (self referenced), such as a "parent" column. The assumption is that a record cannot be its own parent.

init_value

Populate $field->value with object ids from the CDBI object. If the column expands to more than one object then an array ref is set.

validate_model

Validates fields that are dependent on the model. Currently, "unique" fields are checked to make sure they are unique.

This validation happens after other form validation. The form already has any field values entered in $field->value at this point.

validate_unique

Checks that the value for the field is not currently in the database.

items_same

Returns true if the two passed in cdbi objects are the same object. If both are undefined returns true.

obj_key

returns a key for a given object, or undef if the object is undefined.

AUTHOR

FormHandler Contributors - see HTML::FormHandler

COPYRIGHT AND LICENSE

This software is copyright (c) 2017 by Gerda Shank.

This is free software; you can redistribute it and/or modify it under the same terms as the Perl 5 programming language system itself.