NAME
Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks
DESCRIPTION
Conway discourages using unless
because it leads to double-negatives that are hard to understand. Instead, reverse the logic and use if
.
unless
(
$condition
) { do_something() }
#not ok
unless
(!
$no_flag
) { do_something() }
#really bad
if
( !
$condition
) { do_something() }
#ok
This Policy only covers the block-form of unless
. For the postfix variety, see ProhibitPostfixControls
.
SEE ALSO
Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls
AUTHOR
Jeffrey Ryan Thalhammer <thaljef@cpan.org>
COPYRIGHT
Copyright (c) 2005-2006 Jeffrey Ryan Thalhammer. All rights reserved.
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.