NAME

Perl::Critic::Policy::Modules::ProhibitAutomaticExportation

DESCRIPTION

When using Exporter, symbols placed in the @EXPORT variable are automatically exported into the caller's namespace. Although convenient, this practice is not polite, and may cause serious problems if the caller declares the same symbols. The best practice is to place your symbols in @EXPORT_OK or %EXPORT_TAGS and let the caller choose exactly which symbols to export.

package Foo;

use base qw(Exporter);
our @EXPORT      = qw(&foo &bar);                  # not ok
our @EXPORT_OK   = qw(&foo &bar);                  # ok
our %EXPORT_TAGS = ( all => [ qw(&foo &bar) ] );   # ok

AUTHOR

Jeffrey Ryan Thalhammer <thaljef@cpan.org>

COPYRIGHT

Copyright (c) 2005-2007 Jeffrey Ryan Thalhammer. All rights reserved.

This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.