—##############################################################################
# $Date: 2007-12-16 13:14:12 -0600 (Sun, 16 Dec 2007) $
# $Author: clonezone $
# $Revision: 2047 $
##############################################################################
use
strict;
use
warnings;
use
Readonly;
our
$VERSION
=
'1.081_002'
;
#-----------------------------------------------------------------------------
Readonly::Scalar
my
$PACKAGE_RX
=>
qr/ :: /
mx;
Readonly::Scalar
my
$MIXED_RX
=>
qr{ \p{IsUpper}
\p{IsLower} |
\p{IsLower}\p{IsUpper} }mx;
Readonly::Scalar
my
$DESC
=>
'Mixed-case variable name(s)'
;
Readonly::Scalar
my
$EXPL
=> [ 44 ];
#-----------------------------------------------------------------------------
sub
supported_parameters {
return
() }
sub
default_severity {
return
$SEVERITY_LOWEST
}
sub
default_themes {
return
qw( core pbp cosmetic )
}
sub
applies_to {
return
'PPI::Statement::Variable'
}
#-----------------------------------------------------------------------------
sub
violates {
my
(
$self
,
$elem
,
undef
) =
@_
;
if
( _has_mixed_case_vars(
$elem
) ) {
return
$self
->violation(
$DESC
,
$EXPL
,
$elem
);
}
return
;
#ok!
}
sub
_has_mixed_case_vars {
my
$elem
=
shift
;
for
my
$variable_name
(
$elem
->variables() ) {
#Variables with fully qualified package names are exempt
#because we can't really be responsible for symbols that
#are defined in other packages.
next
if
$elem
->type() eq
'local'
&&
$variable_name
=~ m/
$PACKAGE_RX
/xms;
return
1
if
$variable_name
=~ m/
$MIXED_RX
/xms;
}
return
0;
}
1;
__END__
#-----------------------------------------------------------------------------
=pod
=head1 NAME
Perl::Critic::Policy::NamingConventions::ProhibitMixedCaseVars
=head1 DESCRIPTION
Conway's recommended naming convention is to use lower-case words
separated by underscores. Well-recognized acronyms can be in ALL
CAPS, but must be separated by underscores from other parts of the
name.
my $foo_bar #ok
my $foo_BAR #ok
my @FOO_bar #ok
my %FOO_BAR #ok
my $FooBar #not ok
my $FOObar #not ok
my @fooBAR #not ok
my %fooBar #not ok
=head1 SEE ALSO
L<Perl::Critic::Policy::NamingConventions::ProhibitMixedCaseSubs>
=head1 AUTHOR
Jeffrey Ryan Thalhammer <thaljef@cpan.org>
=head1 COPYRIGHT
Copyright (c) 2005-2007 Jeffrey Ryan Thalhammer. All rights reserved.
This program is free software; you can redistribute it and/or modify
it under the same terms as Perl itself. The full text of this license
can be found in the LICENSE file included with this module.
=cut
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab :