/ 
Perl-Critic-Bangs-0.20
River stage two • 8 direct dependents • 13 total dependents
/ Perl::Critic::Policy::Bangs::ProhibitNumberedNames

NAME

Perl::Critic::Policy::Bangs::ProhibitNumberedNames - Prohibit variables differentiated by trailing numbers

DESCRIPTION

Similar variables should be obviously different. A lazy way to differentiate similar variables is by tacking a number at the end.

my $total = $price * $quantity;
my $total2 = $total + ($total * $taxrate);
my $total3 = $total2 + $shipping;

The difference between $total and $total3 is not described by the silly "3" at the end. Instead, it should be:

my $merch_total = $price * $quantity;
my $subtotal = $merch_total + ($merch_total * $taxrate);
my $grand_total = $subtotal + $shipping;

See http://www.oreillynet.com/onlamp/blog/2004/03/the_worlds_two_worst_variable.html for more of my ranting on this.

CONSTRUCTOR

Takes no configuration.

AUTHOR

Andy Lester <andy at petdance.com> from code by Andrew Moore <amoore at mooresystems.com>.

ACKNOWLEDGEMENTS

Adapted from policies by Jeffrey Ryan Thalhammer <thaljef@cpan.org>, Based on App::Fluff by Andy Lester, "<andy at petdance.com>"

COPYRIGHT

Copyright (c) 2006 Andy Lester. All rights reserved.

This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.