NAME

Perl::Critic::Policy::Variables::ProhibitLocalVars

DESCRIPTION

Since Perl 5, there are very few reasons to declare local variables. The only reasonable exceptions are Perl's magical global variables. If you do need to modify one of those global variables, you should localize it first. You should also use the English module to give those variables more meaningful names.

local $foo;   #not ok
my $foo;      #ok

use English qw(-no_match_vars);
local $INPUT_RECORD_SEPARATOR    #ok
local $RS                        #ok
local $/;                        #not ok

NOTES

This policy will give a false negative if you put mutliple variables in a single local declarations. This due to is a limitation (or bug) in the variables method of PPI::Statement::Variable, and I think it will probably be addressed soon. Otherwise, I have an idea for a workaround.

SEE ALSO

Perl::Critic::Policy::Variables::ProhibitPunctuationVars

AUTHOR

Jeffrey Ryan Thalhammer <thaljef@cpan.org>

Copyright (c) 2005 Jeffrey Ryan Thalhammer. All rights reserved.

This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.